bugfix: support building docker image on openjdk23 #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6984 +/- ##
============================================
+ Coverage 52.66% 52.67% +0.01%
- Complexity 6571 6573 +2
============================================
Files 1125 1125
Lines 39923 39923
Branches 4677 4677
============================================
+ Hits 21026 21030 +4
+ Misses 16898 16894 -4
Partials 1999 1999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Support building Seata Server Docker Image on OpenJDK23.
Ⅱ. Does this pull request fix one issue?
resolve #6965
Ⅲ. Why don't you add test cases (unit test/integration test)?
Not applicable.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Since there’s no key for
apache/seata-serveron Docker Hub, I had to verify it using my own image. You can view the builtseata-serverimage via this link.因为没有apache/seata-server 在dockerhub上的密钥。因此我只能通过自己的账号进行验证。可以通过这个链接 来查看构建完成的seata-server镜像。
There are other possible fixes, but I believe upgrading the version is the best approach. According to the Jib official announcement, this issue was addressed in version 3.3.0.
事实上还有其他的修复方式。但我认为升级版本是最好的解决方法。根据 jib官方公告中的宣称，它们在3.3.0版本中支持了该问题。